Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fastavro version used in Feast to avoid Timestamp delta error #490

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Fix fastavro version used in Feast to avoid Timestamp delta error #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24202d6
Fix fastavro version used in feast to 0.22.9
davidheryanto Feb 24, 2020
4958254
Print python packages version used when e2e test fails
davidheryanto Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .prow/scripts/test-end-to-end-batch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,9 @@ if [[ ${TEST_EXIT_CODE} != 0 ]]; then
echo "[DEBUG] Printing logs"
ls -ltrh /var/log/feast*
cat /var/log/feast-serving-warehouse.log /var/log/feast-core.log

echo "[DEBUG] Printing Python packages list"
pip list
fi

cd ${ORIGINAL_DIR}
Expand Down
3 changes: 3 additions & 0 deletions .prow/scripts/test-end-to-end.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ if [[ ${TEST_EXIT_CODE} != 0 ]]; then
echo "[DEBUG] Printing logs"
ls -ltrh /var/log/feast*
cat /var/log/feast-serving-online.log /var/log/feast-core.log

echo "[DEBUG] Printing Python packages list"
pip list
fi

cd ${ORIGINAL_DIR}
Expand Down
4 changes: 3 additions & 1 deletion sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
"pandavro==1.5.*",
"protobuf>=3.10",
"PyYAML==5.1.*",
"fastavro==0.*",
# fastavro 0.22.10 and newer will throw this error for e2e batch test:
# TypeError: Timestamp subtraction must have the same timezones or no timezones
"fastavro==0.22.9",
"kafka-python==1.*",
"tabulate==0.8.*",
"toml==0.10.*",
Expand Down