Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport ci changes #609

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Backport ci changes #609

merged 2 commits into from
Apr 7, 2020

Conversation

khorshuheng
Copy link
Collaborator

@khorshuheng khorshuheng commented Apr 7, 2020 •
edited
Loading

Move CI scripts from .prow to infra

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: khorshuheng
To complete the pull request process, please assign woop
You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented Apr 7, 2020

This is a lot more than just CI, it also contains Python SDK changes.

@khorshuheng khorshuheng force-pushed the backport-ci-changes branch 2 times, most recently from 1b98653 to 1d77d88 Compare April 7, 2020 08:49
@khorshuheng
Copy link
Collaborator Author

This is a lot more than just CI, it also contains Python SDK changes.

I ended up doing this manually rather than cherry pick the commits, as there are quite a lot of conflicts. I noticed that Python and Golang test no longer appears, not too sure why is that the case though.

@khorshuheng khorshuheng merged commit dcd95ba into feast-dev:v0.4-branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidheryanto davidheryanto Awaiting requested review from davidheryanto davidheryanto is a code owner

@pradithya pradithya Awaiting requested review from pradithya pradithya is a code owner

@woop woop Awaiting requested review from woop woop is a code owner

@zhilingc zhilingc Awaiting requested review from zhilingc zhilingc is a code owner

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khorshuheng @feast-ci-bot @woop