Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bigquery config for serving store #644

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Fix bigquery config for serving store #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb302ac
Change hyphens to underscores to follow proto
Apr 22, 2020
2832d80
Remove bigquery prefix
Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions serving/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ feast:
# to download the batch features.
# For example: gs://mybucket/myprefix
# Please omit the trailing slash in the URI.
staging-location: gs://mybucket/myprefix
staging_location: gs://mybucket/myprefix
# Retry options for BigQuery retrieval jobs
bigquery-initial-retry-delay-secs: 1
initial_retry_delay_seconds: 1
# BigQuery timeout for retrieval jobs
bigquery-total-timeout-secs: 21600
total_timeout_seconds: 21600
subscriptions:
- name: "*"
project: "*"
Expand Down
8 changes: 4 additions & 4 deletions ...rc/main/java/feast/storage/connectors/bigquery/retriever/BigQueryHistoricalRetriever.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public static HistoricalRetriever create(Map<String, String> config) {
BigQuery bigquery = BigQueryOptions.getDefaultInstance().getService();
Storage storage = StorageOptions.getDefaultInstance().getService();

String jobStagingLocation = config.get("staging-location");
String jobStagingLocation = config.get("staging_location");
if (!jobStagingLocation.contains("://")) {
throw new IllegalArgumentException(
String.format("jobStagingLocation is not a valid URI: %s", jobStagingLocation));
Expand All @@ -73,9 +73,9 @@ public static HistoricalRetriever create(Map<String, String> config) {
.setBigquery(bigquery)
.setDatasetId(config.get("dataset_id"))
.setProjectId(config.get("project_id"))
.setJobStagingLocation(config.get("staging-location"))
.setInitialRetryDelaySecs(Integer.parseInt(config.get("bigquery-initial-retry-delay-secs")))
.setTotalTimeoutSecs(Integer.parseInt(config.get("bigquery-total-timeout-secs")))
.setJobStagingLocation(config.get("staging_location"))
.setInitialRetryDelaySecs(Integer.parseInt(config.get("initial_retry_delay_seconds")))
.setTotalTimeoutSecs(Integer.parseInt(config.get("total_timeout_seconds")))
.setStorage(storage)
.build();
}
Expand Down