Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #566 & #647 to v0.3 #654

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

ches
Copy link
Member

@ches ches commented Apr 26, 2020

What this PR does / why we need it:

The indexes added in #566 are an important fix. They weren't backported for v0.3 yet, so this does that in one combined commit of #566 and its bug fix #647.

The inverse join column name in v0.3 was feature_set_id, not feature_sets_id (which is a bit weird honestly and it was either a breaking change for v0.4 when projects were added, or backporting it to v0.4 was actually a breaking change mid-v0.4, I'm not sure which yet—see the blame walk below).

I've preserved feature_set_id so this is not a breaking change for v0.3.

Walking the blames of feature_sets_id:

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ches
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ches
Copy link
Member Author

ches commented Apr 26, 2020

/assign @zhilingc

@ches
Copy link
Member Author

ches commented Apr 26, 2020

Guessing the CI build for v0.3 might be a goner at this point 😅

@khorshuheng
Copy link
Collaborator

Guessing the CI build for v0.3 might be a goner at this point 😅

Most likely related to this: #657

@ches
Copy link
Member Author

ches commented Apr 27, 2020

Most likely related to this: #657

Yep, I saw your PR backporting the change to v0.4, I will take a look into doing the same for v0.3 soon since it's still relevant for us.

@ches
Copy link
Member Author

ches commented Apr 27, 2020

Oh you already did, #657 is the new backport 🎉

@woop
Copy link
Member

woop commented Apr 27, 2020

/retest

@khorshuheng
Copy link
Collaborator

/lgtm

@ches ches merged commit a68ddf2 into feast-dev:v0.3-branch Apr 27, 2020
@ches ches deleted the v0.3-backport-647 branch April 27, 2020 13:28
@ches ches mentioned this pull request May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants