-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #566 & #647 to v0.3 #654
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ches The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @zhilingc |
Guessing the CI build for v0.3 might be a goner at this point 😅 |
Most likely related to this: #657 |
Yep, I saw your PR backporting the change to v0.4, I will take a look into doing the same for v0.3 soon since it's still relevant for us. |
Oh you already did, #657 is the new backport 🎉 |
/retest |
/lgtm |
What this PR does / why we need it:
The indexes added in #566 are an important fix. They weren't backported for v0.3 yet, so this does that in one combined commit of #566 and its bug fix #647.
The inverse join column name in v0.3 was
feature_set_id
, notfeature_sets_id
(which is a bit weird honestly and it was either a breaking change for v0.4 when projects were added, or backporting it to v0.4 was actually a breaking change mid-v0.4, I'm not sure which yet—see the blame walk below).I've preserved
feature_set_id
so this is not a breaking change for v0.3.Walking the blames of
feature_sets_id
: