Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in all types parquet yml file (e2e test) #683

Merged
merged 1 commit into from
May 8, 2020

Conversation

khorshuheng
Copy link
Collaborator

What this PR does / why we need it:
The typo in the e2e test feature set yaml cause the feature set to be registered incorrectly, which is the likely reason as to why the e2e test failed in #676.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member

woop commented May 8, 2020

/lgtm

@khorshuheng
Copy link
Collaborator Author

/test test-end-to-end-batch

1 similar comment
@khorshuheng
Copy link
Collaborator Author

/test test-end-to-end-batch

@khorshuheng
Copy link
Collaborator Author

/test test-end-to-end-redis-cluster

@feast-ci-bot feast-ci-bot merged commit cc118eb into feast-dev:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants