Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include server port config on the generated application.yml #696

Merged
merged 2 commits into from
May 13, 2020
Merged

Include server port config on the generated application.yml #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc33af1
Include server port config on the generated application.yml
khorshuheng May 13, 2020
69318f2
Add additional documentation
khorshuheng May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infra/charts/feast/charts/feast-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@ Current chart version is `0.5.0-alpha.1`
| service.grpc.targetPort | int | `6565` | Container port serving GRPC requests |
| service.http.nodePort | string | `nil` | Port number that each cluster node will listen to |
| service.http.port | int | `80` | Service port for HTTP requests |
| service.http.targetPort | int | `8080` | Container port serving HTTP requests |
| service.http.targetPort | int | `8080` | Container port serving HTTP requests and Prometheus metrics |
| service.type | string | `"ClusterIP"` | Kubernetes service type |
3 changes: 3 additions & 0 deletions infra/charts/feast/charts/feast-core/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ data:
type: statsd
host: {{ .Release.Name }}-prometheus-statsd-exporter-udp
port: 9125

server:
port: {{ .Values.service.http.targetPort }}
{{- end }}

application-override.yaml: |
Expand Down
4 changes: 2 additions & 2 deletions infra/charts/feast/charts/feast-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ application.yaml:
enabled: true

application-generated.yaml:
# "application-generated.yaml".enabled -- Flag to include Helm generated configuration for Feast database URL, Kafka bootstrap servers and jobs metrics host. This is useful for deployment that uses default configuration for Kafka, Postgres and StatsD exporter. Please set `application-override.yaml` to override this configuration.
# "application-generated.yaml".enabled -- Flag to include Helm generated configuration for http port, Feast database URL, Kafka bootstrap servers and jobs metrics host. This is useful for deployment that uses default configuration for Kafka, Postgres and StatsD exporter. Please set `application-override.yaml` to override this configuration.
enabled: true

# "application-secret.yaml" -- Configuration to override the default [application.yaml](https://github.com/gojek/feast/blob/master/core/src/main/resources/application.yml). Will be created as a Secret. `application-override.yaml` has a higher precedence than `application-secret.yaml`. It is recommended to either set `application-override.yaml` or `application-secret.yaml` only to simplify config management.
Expand Down Expand Up @@ -89,7 +89,7 @@ service:
http:
# service.http.port -- Service port for HTTP requests
port: 80
# service.http.targetPort -- Container port serving HTTP requests
# service.http.targetPort -- Container port serving HTTP requests and Prometheus metrics
targetPort: 8080
# service.http.nodePort -- Port number that each cluster node will listen to
nodePort:
Expand Down
3 changes: 3 additions & 0 deletions infra/charts/feast/charts/feast-serving/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ data:
job_store:
redis_host: {{ .Release.Name }}-redis-master
redis_port: 6379

server:
port: {{ .Values.service.http.targetPort }}
{{- end }}

application-override.yaml: |
Expand Down
4 changes: 2 additions & 2 deletions infra/charts/feast/charts/feast-serving/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ application.yaml:
enabled: true

application-generated.yaml:
# "application-generated.yaml".enabled -- Flag to include Helm generated configuration for Feast Core host, Redis store and job store. This is useful for deployment that uses default configuration for Redis. Please set `application-override.yaml` to override this configuration.
# "application-generated.yaml".enabled -- Flag to include Helm generated configuration for http port, Feast Core host, Redis store and job store. This is useful for deployment that uses default configuration for Redis. Please set `application-override.yaml` to override this configuration.
enabled: true

# "application-secret.yaml" -- Configuration to override the default [application.yaml](https://github.com/gojek/feast/blob/master/serving/src/main/resources/application.yml). Will be created as a Secret. `application-override.yaml` has a higher precedence than `application-secret.yaml`. It is recommended to either set `application-override.yaml` or `application-secret.yaml` only to simplify config management.
Expand Down Expand Up @@ -84,7 +84,7 @@ service:
http:
# service.http.port -- Service port for HTTP requests
port: 80
# service.http.targetPort -- Container port serving HTTP requests
# service.http.targetPort -- Container port serving HTTP requests and Prometheus metrics
targetPort: 8080
# service.http.nodePort -- Port number that each cluster node will listen to
nodePort:
Expand Down