-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .proto to packages of Protobuf generated Java classes #700
Conversation
83e7649
to
39ace30
Compare
/test test-end-to-end-batch |
1 similar comment
/test test-end-to-end-batch |
436c8b4
to
4fa3954
Compare
/test test-end-to-end-batch |
/lgtm Hope there isn't a reason to hold this—there's no hold label—but it's potentially a big merge conflict pain waiting for anyone who branches before this gets in, so if we want it let's get it done. Anyone with already open PRs, yell at @woop not me 😉 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ches, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think there will be yelling, but it won't be because of this :) We've had a long running Mexican standoff between PRs for a while now, so I have asked @mrzzy to just squash his history into a single commit (well it's 4 now) so that he doesn't lose years of his life rebasing. Anyway, thanks for getting this merged in! |
What this PR does / why we need it:
Adds
.proto
to the package of Java generated proto code in order to differentiate it from non-proto code.Example:
feast.core.CoreServiceGrpc
tofeast.proto.core.CoreServiceGrpc
Which issue(s) this PR fixes:
Fixes #684
Does this PR introduce a user-facing change?: