Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that batch retrieval tests clean up after themselves #704

Merged
merged 3 commits into from
May 15, 2020

Conversation

zhilingc
Copy link
Collaborator

What this PR does / why we need it:
Also added some time buffer for the batch retrieval file tests so we're not at the mercy of float rounding when converting between df and file.

Which issue(s) this PR fixes:

Fixes #702

Does this PR introduce a user-facing change?:


@zhilingc
Copy link
Collaborator Author

/test test-end-to-end-batch

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator

/approve

@khorshuheng
Copy link
Collaborator

/test test-end-to-end-batch

@zhilingc
Copy link
Collaborator Author

/hold

@zhilingc
Copy link
Collaborator Author

/unhold

@khorshuheng
Copy link
Collaborator

/lgtm

@khorshuheng
Copy link
Collaborator

/approve

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khorshuheng, zhilingc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [khorshuheng,zhilingc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 8ab00e0 into feast-dev:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End to end tests do not properly clean up resources
3 participants