Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Optional#get() and string comparison bugs in JobService #804

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Fix Optional#get() and string comparison bugs in JobService #804

merged 2 commits into from
Jun 18, 2020

Commits on Jun 18, 2020

  1. Fix Optional#get() and string comparison bugs in JobService 

    Clears a FIXME left from #650, get() uses that will always fail.

Also fixes a bunch of == comparisons on strings, reference equality is
not what you want there.
    @ches
    ches committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    3697c78 View commit details
    Browse the repository at this point in the history

  2. Hide Maven transfer progress, for CI 

    It makes trying to read output in GitHub Actions horrible. Seeing
failures in red is kind of nice, so `--no-transfer-progress` keeps
colors unlike `--batch-mode`.
    @ches
    ches committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    846bad5 View commit details
    Browse the repository at this point in the history