Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest instead of dev as the default image tag in helm charts #806

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

duongnt
Copy link
Contributor

@duongnt duongnt commented Jun 18, 2020

What this PR does / why we need it: Image tag default is currently dev, which might change very often and might include bugs and breaking changes.

Which issue(s) this PR fixes: Fixes #805

Does this PR introduce a user-facing change?: No

@feast-ci-bot
Copy link
Collaborator

Hi @duongnt. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Jun 19, 2020

@duongnt Apologies for letting this slip through our radar. Thank you for the submission.

@woop
Copy link
Member

woop commented Jun 19, 2020

/ok-to-test

@feast-ci-bot
Copy link
Collaborator

@woop: The label(s) kind/kind/housekeeping cannot be applied, because the repository doesn't have them

In response to this:

/kind kind/housekeeping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@feast-ci-bot
Copy link
Collaborator

@woop: The label(s) kind/kind/housekeeping cannot be applied, because the repository doesn't have them

In response to this:

/kind kind/housekeeping

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Jun 19, 2020

/kind housekeeping

@woop
Copy link
Member

woop commented Jun 19, 2020

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: duongnt, woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit a74a484 into feast-dev:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a stable image tag instead of dev as default in helm charts
3 participants