Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable isort for Python SDK #843

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Enable isort for Python SDK #843

merged 3 commits into from
Jun 30, 2020

Conversation

woop
Copy link
Member

@woop woop commented Jun 30, 2020

What this PR does / why we need it:

Enables isort checks for the Python SDK and e2e tests.

Contributors should use make format in order to sort their code, and make lint in order to validate that their Python code is correctly sorted.

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@woop
Copy link
Member Author

woop commented Jun 30, 2020

/kind housekeeping

@woop woop merged commit 662f867 into feast-dev:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants