Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX doesn't always have sched_getaffinity #850

Conversation

Wirick
Copy link
Contributor

@Wirick Wirick commented Jun 30, 2020

  1. The python client breaks when calling
    CPU_COUNT: int = len(os.sched_getaffinity(0))

What this PR does / why we need it:
When importing the python client I encounter an error

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'os' has no attribute 'sched_getaffinity'

We should fallback or use another trick to compute this value, it seems to be a known issue
https://stackoverflow.com/questions/42538153/python-3-6-0-os-module-does-not-have-sched-getaffinity-method

1. The python client breaks when calling
 CPU_COUNT: int = len(os.sched_getaffinity(0))
@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Wirick
To complete the pull request process, please assign pyalex
You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @Wirick. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrzzy
Copy link
Collaborator

mrzzy commented Jul 1, 2020

@Wirick Thanks for this. However, this seems to be a duplicate of #839?

@Wirick
Copy link
Contributor Author

Wirick commented Jul 1, 2020

didn't even see it just fixed in the dev process

@Wirick Wirick closed this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants