Improve parallelization in Redis Sink #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyalex
requested review from
davidheryanto,
khorshuheng,
woop and
zhilingc
as code owners
woop
reviewed
Jul 9, 2020
storage/connectors/redis/src/main/java/feast/storage/connectors/redis/writer/RedisCustomIO.java
Show resolved
Hide resolved
woop
reviewed
Jul 9, 2020
...e/connectors/redis/src/main/java/feast/storage/connectors/redis/writer/RedisFeatureSink.java
Outdated
Show resolved
Hide resolved
pyalex
force-pushed
the
fix-redis-batch
branch
2 times, most recently
from
2a12816 to
7a46f7f
Compare
|
/test test-end-to-end-auth |
|
/test test-end-to-end-auth |
|
/lgtm |
woop
approved these changes
Jul 13, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pyalex
pushed a commit
to pyalex/feast
that referenced
this pull request
Jul 17, 2020
* replace group with batch * featureReference as key * configurable flush frequncy in redis sink * pull config to RedisSink
pyalex
pushed a commit
that referenced
this pull request
Jul 17, 2020
* replace group with batch * featureReference as key * configurable flush frequncy in redis sink * pull config to RedisSink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In redis sink we pack rows into batches before actually flush them to redis. Current implementation use GroupBy null (all rows into one group) which cause a lot of shuffling. It could lead to significant throughput degradation. This PR replaces GroupBy with GroupIntoBatches with FeatureReference used as key. This should improve parallelization of Redis Sink
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: