Fix Python SDK setuptools not supporting tags required for Go SDK to be versioned. #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzzy
requested review from
davidheryanto,
khorshuheng,
pyalex,
woop and
zhilingc
as code owners
…tuptools_scm Required to prevent setuptools_scm from crashing due to 'sdk/go/*' tags introduced to support golang SDK retrieval by version.
|
Do these tags also get pushed to Pypi? |
|
The regex extracts the version part of the tag and uses that to output the version instead using the We can manually verify this by:
from setuptools_scm import get_version
params={"root": "../..", "relative_to": __file__, "tag_regex": TAG_REGEX}
version = get_version(**params)
print(version)prints So the Pypi package should be tagged correctly. |
woop
approved these changes
Sep 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrzzy, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test test-end-to-end-batch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added custom regex to parse versions to
setuptools_scmused by the Python SDK to parse SemVer versions:setup.py.Which issue(s) this PR fixes:
Fixes #824 once new go
sdk/go/*tags are introduced.Does this PR introduce a user-facing change?: