Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeVerification not suitable as an after find hook #55

Closed
sylvainlap opened this issue Jul 5, 2017 · 4 comments · Fixed by #84
Closed

removeVerification not suitable as an after find hook #55

sylvainlap opened this issue Jul 5, 2017 · 4 comments · Fixed by #84
Labels
Bug

Comments

@sylvainlap
Copy link
Contributor

In this line: https://github.com/feathersjs/feathers-authentication-management/blob/master/src/hooks.js#L40, removeVerification hook consider that result is a user.

However, in a find hook, result could be a paginated data.
@eddyystop eddyystop added the Bug label Jul 5, 2017
@eddyystop
Copy link
Collaborator

eddyystop commented Jul 5, 2017 •
edited
Loading

The hook was not intended to be used with a find, but it should be able to handle it. Thanks.

Where did you find docs for this repo? I can't find them anymore in docs.feathersjs.com.

edit: daffl had thankfully stashed them in doc.md back in April.

@eddyystop
Copy link
Collaborator

I'll handle this when I have time.

@sylvainlap
Copy link
Contributor Author

I don't think that feathers-auth-management docs are available on docs.feathersjs.com

@eddyystop
Copy link
Collaborator

They've been restored now.

@claustres claustres mentioned this issue Jan 5, 2018
Closed
claustres added a commit to kalisio/feathers-authentication-management that referenced this issue Jan 7, 2018
@claustres
Fix for feathersjs-ecosystem#55
f88d4c3
@claustres claustres mentioned this issue Jan 7, 2018
Merged
eddyystop added a commit that referenced this issue Jan 10, 2018
@eddyystop
Merge pull request #84 from kalisio/master
7481323 
Fix for #55
lwhiteley pushed a commit to lwhiteley/feathers-authentication-management that referenced this issue Jan 23, 2018
@claustres
Fix for feathersjs-ecosystem#55
0e346a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #55 kalisio/feathers-authentication-management
2 participants
@eddyystop @sylvainlap