migrate to featchers-common-hooks v4 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
|
Could you please release a new version where this is included, still receiving these warnings on |
|
I'll have to look at why the tests are failing. |
|
I pushed a commit directly to the master branch bumping feathers-hooks-common to ^4.14.1 . Published as v2.0..1. This was not done as a PR because the tests now fail and I don't see how to fix them without a rewrite. Basically some of the .then() are still suspended when Mocha gets control from the test. They only continue to run after the Mocha test timesout. This'll have to wait until the rewrite planned for this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecation dependency warnings.
Update to latest feathers-hooks-common? #94
No