-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass notifierOptions every were that notifier is called. #155
Conversation
…er... {} to 'password'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the approach, although I'm not seeing any changes or additions to unit tests
…id token... {} to { transport: 'sms' }
I've seen that you made a release after merging this PR. There are actually dedicated scripts in the module to do so, you need to run eg We should probably add something in the docs about that. Let me know. |
@claustres That was a mistake I made. I actually ran Ya adding more info in the docs would be great! |
Will try to fix it, would also be great to fill the PR description to know what problem is solved. |
I've just added this. Hope this will help. |
Summary
This PR allows you to pass notifierOptions for all actions that call the notifier function.
sendResetPwd
action had this already implemented.(If you have not already please refer to the contributing guideline as described
here)
If so, please mention them to keep the conversations linked together.
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! ❤️