Fix for #55

src/hooks.js

@@ -2,7 +2,7 @@
 /* eslint no-param-reassign: 0 */
 
 const errors = require('feathers-errors');
-const { checkContext } = require('feathers-hooks-common');
+const { checkContext, getItems, replaceItems } = require('feathers-hooks-common');
 const { getLongToken, getShortToken, ensureFieldHasChanged } = require('./helpers');
 
 module.exports.addVerification = path => hook => {
@@ -49,25 +49,33 @@ module.exports.isVerified = () => hook => {
 
 module.exports.removeVerification = ifReturnTokens => hook => {
   checkContext(hook, 'after');
-  const user = hook.result || {};
-
-  if (!('isVerified' in user) && hook.method === 'create') {
-    /* eslint-disable no-console */
-    console.warn('Property isVerified not found in user properties. (removeVerification)');
-    console.warn('Have you added authManagement\'s properties to your model? (Refer to README.md)');
-    console.warn('Have you added the addVerification hook on users::create?');
-    /* eslint-enable */
-  }
+  // Retrieve the items from the hook
+  let users = getItems(hook)
+  if (!users) return
+  const isArray = Array.isArray(users)
+  users = (isArray ? users : [users])
+
+  users.forEach(user => {
+    if (!('isVerified' in user) && hook.method === 'create') {
+      /* eslint-disable no-console */
+      console.warn('Property isVerified not found in user properties. (removeVerification)');
+      console.warn('Have you added authManagement\'s properties to your model? (Refer to README.md)');
+      console.warn('Have you added the addVerification hook on users::create?');
+      /* eslint-enable */
+    }
 
-  if (hook.params.provider && user) { // noop if initiated by server
-    delete user.verifyExpires;
-    delete user.resetExpires;
-    delete user.verifyChanges;
-    if (!ifReturnTokens) {
-      delete user.verifyToken;
-      delete user.verifyShortToken;
-      delete user.resetToken;
-      delete user.resetShortToken;
+    if (hook.params.provider && user) { // noop if initiated by server
+      delete user.verifyExpires;
+      delete user.resetExpires;
+      delete user.verifyChanges;
+      if (!ifReturnTokens) {
+        delete user.verifyToken;
+        delete user.verifyShortToken;
+        delete user.resetToken;
+        delete user.resetShortToken;
+      }
     }
-  }
+  })
+  // Replace the items within the hook
+  replaceItems(hook, isArray ? users : users[0])
 };

test/removeVerification.test.js

@@ -39,7 +39,7 @@ describe('hook:remove verification', () => {
     assert.notProperty(user, 'verifyChanges');
   });
 
-  it('works with unverified used', () => {
+  it('works with unverified user', () => {
     hookIn.result.isVerified = false;
 
     assert.doesNotThrow(() => { hooks.removeVerification()(hookIn); });
@@ -74,7 +74,22 @@ describe('hook:remove verification', () => {
     assert.property(user, 'verifyChanges');
   });
 
-  it('throws with damaged hook', () => {
+  it('works with multiple verified user', () => {
+    hookIn.result = [hookIn.result, hookIn.result]
+    assert.doesNotThrow(() => { hooks.removeVerification()(hookIn); });
+
+    hookIn.result.forEach(user => {
+      assert.property(user, 'isVerified');
+      assert.equal(user.isVerified, true);
+      assert.notProperty(user, 'verifyToken');
+      assert.notProperty(user, 'verifyExpires');
+      assert.notProperty(user, 'resetToken');
+      assert.notProperty(user, 'resetExpires');
+      assert.notProperty(user, 'verifyChanges');
+    })
+  });
+
+  it('does not throw with damaged hook', () => {
     delete hookIn.result;
 
     assert.doesNotThrow(() => { hooks.removeVerification()(hookIn); });