Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use underscores to donate filter params vs. params that are on a model #17

Closed
ekryski opened this issue Mar 6, 2015 · 3 comments
Closed

Should use underscores to donate filter params vs. params that are on a model #17

ekryski opened this issue Mar 6, 2015 · 3 comments

Comments

@ekryski
Copy link
Member

ekryski commented Mar 6, 2015

No description provided.

@marshallswain
Copy link
Member

Why not just use $ ? It would be nice to "standardize" how this should work across services. I'll be making a MySQL service sometime and think it would be nice to have similarities in the query/filter params. Other than doing MySQL-specific operations like maybe $join, it would be nice for the API to match as much as possible. I used $ in feathers-mongoose-advanced just to match what MongoDB is already using.

@ekryski
Copy link
Member Author

ekryski commented Jul 28, 2015

Agreed. $ it is. PR is coming that will close this and make it consistent between all adapters.

@daffl
Copy link
Member

daffl commented Jul 28, 2015

👍

@ekryski ekryski mentioned this issue Jul 29, 2015
Merged
ekryski added a commit that referenced this issue Aug 5, 2015
@ekryski
Merge pull request #18 from feathersjs/pre-release
facae4a 
Release 2.0.0.

Closes #1, #2, #6, #12, #15, #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marshallswain @daffl @ekryski