Added warning msg when options.lean is falsey #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyystop
changed the title
|
|
|
I'd still like to figure out a good way to send deprecation warnings. Plain |
|
This msg is suppressed in production mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People are told on #help they have to configure Mongoose with { lean: true } with some frequency. Hours are lost on this problem. See #help jojobyte posting first Dec 18 2:42am and finding an answer 7:26pm.
Supposedly { lean: true } is either not in or not prominent in the docs. Displaying a console message might help even when people don't read the docs.
No.
Yes.
Other Information
I believe Sequelize has a similar issue. I assume I can made a similar PR for it.