Fix bug where regex fails in error-handler #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am unable to understand why the tests are failing on an unrelated test case to the code I have modified. If someone could explain this to me I am happy to go and make any required changes. Although I am slightly confused as to how a change in this regular expression could cause the tests to fail so perhaps it's an issue with how I edited the error handler tests... |
|
Thank you for the pull request @cdimitroulas! Looks like the error was a bug with a later version of MongoDB and how indexes for some tests were set up. It is fixed now so if you pull latest master and push it tests should pass. |
|
All done! |
|
Awesome, thank you. Released as v6.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The regex inside the
errorHandlerdoes not work correctly for string values. If aConflictoccurs in the database where two string values clash (such as the name"Kate"in the tests) then thevaluevariable was equal to"Kate""before this fix (please notice the extra double quote in the string).This PR fixes that issue. The test cases added fail before the modification to the regex.