fix: handling of params.mongoose in transaction #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend params.mongoose with session instead of replacing it
Summary
Currently beginTransaction overrides the params.mongoose object:
context.params.mongoose = { session };
This causes issues if an operations depends on mongoose/mongodb params, for example when using arrayFilters or upsert (https://docs.mongodb.com/master/reference/method/db.collection.findAndModify/#findandmodify-arrayfilters)
Not sure if there was an intentional design decision behind overwriting it. If so, some sort of whitelisting for options should be included in my opinion.
See desc
No, I just fixed it instead of opening one
No