fix(knex): The method getModel in the knex adapter (#3043)

feathersjs · Feb 7, 2023 · 77e14dd · 77e14dd
1 parent 5380a5c
commit 77e14dd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/knex/src/adapter.ts b/packages/knex/src/adapter.ts
@@ -63,7 +63,7 @@ export class KnexAdapter<
     return this.getModel()
   }
 
-  getModel(params?: ServiceParams) {
+  getModel(params: ServiceParams = {} as ServiceParams) {
     const { Model } = this.getOptions(params)
     return Model
   }

diff --git a/packages/knex/test/overrides.test.ts b/packages/knex/test/overrides.test.ts
@@ -122,4 +122,11 @@ describe('Feathers Knex Overridden Method With Self-Join', () => {
 
     assert.strictEqual(patchedAnimal.name, newName)
   })
+
+  it('get the service model (getModel)', async () => {
+    const model = animalService.Model
+    const options = animalService.options
+
+    assert.strictEqual(model, options.Model)
+  })
 })