[Question] FeathersJS + Apollo Server 2.0

[sxwebdev]

Hey. As you know, recently, the apollo server was updated to version 2.0.
How to use it with current version of feathers?
I generated a new custom service and put next code.

graphql.service.js

const { ApolloServer, gql } = require('apollo-server-express');
module.exports = function (app) {
	const typeDefs = gql`
	type Query {
		hello: String
	}
	`;

	const resolvers = {
		Query: {
			hello: () => 'hello world'
		}
	};
	const server = new ApolloServer({
		typeDefs,
		resolvers,
		context: ({req,res}) => ({
			provider: req.feathers.provider,
			headers: req.feathers.headers
		})
	});
	server.applyMiddleware({ app });
};

When I try to use /graphql path in browser, I get this error
message=Page not found, type=FeathersError, name=NotFound, code=404, className=not-found, url=/graphql, , stack=NotFound: Page not found
Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

How to resolve it? Thanks.

[daffl]

The order when it is called matters and has to happen before the notFound middleware (FAQ reference).

[sxwebdev]

I registered a custom middleware before app.use(express.notFound());

Custom middleware exist in services

[sxwebdev]

If I delete this line app.use(express.notFound());, everything works as expected

[daffl]

There is a chance that server.applyMiddleware probably runs asynchronously. You could try adding the notFound handler after the server has been started and is listening.

[sxwebdev]

You could try adding the notFound handler after the server has been started and is listening.

It did not help

[sxwebdev]

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-server-express/src/ApolloServer.ts#L147

[daffl]

I would test if a standard Express application with a similar notFound handler like

const app = express();

// Apollo server setup here
server.applyMiddleware({ app });

app.use(function (req, res, next) {
  next(new Error('Not found'));
});

Has the same issue.

[sxwebdev]

if set content-type to application/json in Postman - apollo server works correctly.

I think the problem is here:

https://github.com/apollographql/apollo-server/blob/master/packages/apollo-server-express/src/ApolloServer.ts#L147

[sxwebdev]

I would test if a standard Express application with a similar notFound handler like

error: message=Not found, stack=Error: Not found

and then

Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client

[sxwebdev]

If comment this line in ApolloServer.js

everything works fine

[daffl]

That actually looks like a bug in the Apollo server. In Express next should never be called once the middleware calls res.end().

[daffl]

Closing since it wasn't a Feathers issue and has been fixed in Apollo via apollographql/apollo-server#1436

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.