Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update circle ci python image to be consistent with runtime version #3978

Closed
1 task
Tracked by #137
jason-upchurch opened this issue Aug 13, 2020 · 2 comments · Fixed by #4093
Closed
1 task
Tracked by #137

Update circle ci python image to be consistent with runtime version #3978

jason-upchurch opened this issue Aug 13, 2020 · 2 comments · Fixed by #4093
Assignees
@pkfec
Labels
Technical debt Work: Back-end
Milestone
Sprint 13.6

Comments

@jason-upchurch
Copy link
Contributor

jason-upchurch commented Aug 13, 2020 •
edited by pkfec
Loading

What we're after:
Current runtime environment is 3.7.8 as specified by 3.7.x in runtime.txt. However, current circle ci image is 3.7.4 per .config.yml.

Let's make these consistent so that the tests run are with the same version as the runtime environment for our app.

Completion criteria

  • circle ci version are updated to match what's in runtime

Related issues
@jason-upchurch jason-upchurch added this to the Sprint 13.4 milestone Aug 13, 2020
@jason-upchurch jason-upchurch mentioned this issue Aug 14, 2020
Closed
2 tasks
@patphongs patphongs modified the milestones: Sprint 13.4, Sprint 13.5 Aug 31, 2020
@patphongs patphongs modified the milestones: Sprint 13.5, Sprint 13.6 Sep 9, 2020
@pkfec pkfec self-assigned this Sep 30, 2020
@pkfec
Copy link
Contributor

pkfec commented Sep 30, 2020 •
edited
Loading

Python docker image 3.7.8-stretch-node-browsers comes with node v12.18.3 which is incompatible with our current CMS environment. CMS is currently running on node v10.16.3.

@pkfec
Copy link
Contributor

pkfec commented Oct 1, 2020

Node LTS release versions:
Screen Shot 2020-10-01 at 9 49 41 AM

@pkfec pkfec mentioned this issue Oct 2, 2020
Merged
@patphongs patphongs mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkfec pkfec

Labels
Technical debt Work: Back-end
Projects
None yet
Milestone
Sprint 13.6
Development

Successfully merging a pull request may close this issue.

update circleci config fecgov/fec-cms
4 participants
@pkfec @patphongs @JonellaCulmer @jason-upchurch