Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Upgrade jquery to 3.5.1 #501

Merged
merged 2 commits into from
Jun 2, 2020
Merged

Upgrade jquery to 3.5.1 #501

merged 2 commits into from
Jun 2, 2020

Conversation

patphongs
Copy link
Member

Summary

See jquery docs on what was released for 3.5.1: https://blog.jquery.com/2020/05/04/jquery-3-5-1-released-fixing-a-regression/

Impacted areas of the application

Upgraded jQuery from 3.4.1 to 3.5.1
modified: ../package-lock.json
modified: ../package.json

How to test

  • Run inside a python 3.7.7 environment
  • pip install -r requirements.txt
  • pip install -r requirements_dev.txt
  • npm i
  • npm run build
  • python manage.py compile_frontend (if you receive an error about node-gyp python version here, update your npm by running npm install -g npm)
  • python manage.py runserver
  • Spot check things using jquery such as mega menu and glossary

pkfec
pkfec previously approved these changes May 29, 2020
@pkfec
Copy link
Contributor

pkfec commented May 29, 2020

On CLI, I ransnyk test on this feature branch. The jquery vulnerability is no longer showing on this branch. Nice work @patphongs

can you check-in the package-lock.json file that got updated?

@pkfec pkfec dismissed their stale review May 29, 2020 20:10

Both package.json and package-lock.json files got updated. Have to check in both files.

@patphongs
Copy link
Member Author

@pkfec the package lock file is actually generated. So just updating the package.json should be sufficient to have the Jquery package file update on build. Build will install the upgrade based on what is defined in the package.

@patphongs
Copy link
Member Author

Sorry disregard @pkfec, I forgot that we use the lock file to make sure we have the right package file hashes on upgrade. Will do this on Monday. Thanks!

@pkfec
Copy link
Contributor

pkfec commented Jun 1, 2020

Sorry disregard @pkfec, I forgot that we use the lock file to make sure we have the right package file hashes on upgrade. Will do this on Monday. Thanks!

@patphongs I see that you pushed the latest package-lock.json file. LGTM. I will approve this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Snyk: Medium] Cross-site Scripting (XSS) in jquery (Due 06/15/2020)
4 participants