Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Pin urllib3 version #556

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Pin urllib3 version #556

merged 1 commit into from
Dec 21, 2020

Conversation

jason-upchurch
Copy link
Contributor

@jason-upchurch jason-upchurch commented Dec 15, 2020

Summary

resolves #555 by pinning urllib3 version.

How to test

Verify that the error message no longer appears in circle.
ERROR: requests 2.23.0 has requirement urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1, but you'll have urllib3 1.26.0 which is incompatible.

@jason-upchurch jason-upchurch self-assigned this Dec 15, 2020
@jason-upchurch jason-upchurch added this to the Sprint 13.10 milestone Dec 15, 2020
@pkfec
Copy link
Contributor

pkfec commented Dec 18, 2020

@jason-upchurch - Deployed a test branch to dev space. The Install Python Dependencies task is no longer showing the URLLIB incompatibility errors anymore. Thanks for working on this issue.

Latest eregs/ build:
https://app.circleci.com/pipelines/github/fecgov/fec-eregs/202/workflows/c4110971-3219-4523-9ed4-297f8a45d0c7/jobs/526

Screen shot from previous build:
https://app.circleci.com/pipelines/github/fecgov/fec-eregs/200/workflows/79abe464-aa01-4969-bfb8-98903f8c01a9/jobs/523 :
Screen Shot 2020-12-18 at 10 05 06 AM

Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix requests error
3 participants