This repository has been archived by the owner on May 22, 2024. It is now read-only.
Pin dependencies #558
Merged
Pin dependencies #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-upchurch
force-pushed
the
feature/541-fix-django-related-errors
branch
from
24e8db2
to
bef0772
Compare
jason-upchurch
force-pushed
the
feature/541-fix-django-related-errors
branch
from
bef0772
to
9985536
Compare
fec-jli
approved these changes
Dec 21, 2020
pkfec
approved these changes
Dec 21, 2020
There was a problem hiding this comment.
Able to parse 2020 regs with the pinned pkgs on my local. Not seeing any pkg related errors while installing the requirements*. file. Changes looking good @jason-upchurch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #541
How to test
@pkfec @fec-jli , I deployed to dev to verify this works, but probably good for you to test this way as well. Otherwise, just verify nothing looks off to you (I pinned in the requirements_dev.txt because that's where regparser is.