Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Upgrade django #776

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Upgrade django #776

merged 1 commit into from
Jul 31, 2023

Conversation

pkfec
Copy link
Contributor

@pkfec pkfec commented Jul 26, 2023

Summary (required)

This ticket fixes the snyk vulnerbilities in requirements-parsing.txt and requirements.txt. The following packages are upgraded:

  • In requirements.txt
    - django==3.2.20
  • In requirements-parsing.txt
    - django==3.2.20
    - cryptography==41.0.2
    - pygments==2.15.1

Required reviewers 1 developers

Impacted areas of the application

General components of the application that this PR will affect:

  • eregs, regulations-parser, regulations-core, regulations-site repos

Related PRs

  1. Regulations-Parser PR
  2. Regulations-Site PR
  3. Regulations-Core PR

How to test

  1. Checkout this branch
  2. Change regparser, regulations, and regcore to point to my branch in requirements.txt and requirements-parsing.txt

regparser
-e git+https://github.com/fecgov/regulations-parser.git@773-upgrade-django-parser#egg=regparser
regsite
-e git+https://github.com/fecgov/regulations-site@773-upgrade-django-site#egg=regulations
regcore
-e git+https://github.com/fecgov/regulations-core@773-upgrade-django-core#egg=regcore

Terminal One:
3. pyenv virtualenv (your virtual environment)
4. pip install -r requirements.txt
5. snyk test --file=requirements.txt --package-manager=pip
6. rm -rf node_modules
7. npm i
8. npm run build
9. dropdb eregs_local
10. createdb eregs_local
11. python manage.py migrate
12. python manage.py compile_frontend
13. python manage.py runserver (leave running)

Terminal Two:
14. pyenv virtualenv (your virtual environment)
15. pip install -r requirements-parsing.txt
16. snyk test --file=requirements-parsing.txt --package-manager=pip
17. python load_regs/load_fec_regs.py local
18. Go to http://127.0.0.1:8000/ to view 45 regulations

For more detailed instructions follow the wiki on how to setup/parse regulations on local environment

NOTE: Merge other repo PRs first

@pkfec pkfec requested review from tmpayton and cnlucas July 26, 2023 15:36
@pkfec pkfec self-assigned this Jul 26, 2023
@pkfec pkfec changed the title [WIP] Upgrade django Upgrade django Jul 26, 2023
Copy link
Member

@cnlucas cnlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

I'm not sure if the recommended way to pull a remote branch is adding .git or not, it seems to work either way. I would lean towards keeping .git and adding it to the other branches.

Copy link
Contributor

@tmpayton tmpayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@tmpayton tmpayton merged commit c98553f into develop Jul 31, 2023
@pkfec pkfec deleted the feature/773-snyk-redos branch April 8, 2024 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[July 2023] eRegs parsing requirements
3 participants