Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable downloads from candidate pages #2710

Closed
2 tasks
PaulClark2 opened this issue Oct 24, 2017 · 5 comments
Closed
2 tasks

Enable downloads from candidate pages #2710

PaulClark2 opened this issue Oct 24, 2017 · 5 comments
Assignees
Milestone

Comments

@PaulClark2
Copy link
Contributor

PaulClark2 commented Oct 24, 2017

Refactor API to enable downloads from candidate pages

  • research current state of these endpoints
  • make changes to enable downloads

Endpoint: /candidates/totals/

Follow on to redis/celery training session.

@jenniferthibault
Copy link

Currently, these downloads are marked as "Coming soon" on the app interface

screen shot 2017-11-14 at 9 18 51 am

@PaulClark2
Copy link
Contributor Author

I think Carlo and Lindsay hope to use the Redis/Celery training on 11/20 as a kick-off for refactoring these endpoints.

@jwchumley jwchumley modified the milestones: Sprint 4.4, Sprint 4.5 Nov 14, 2017
@PaulClark2 PaulClark2 removed this from the Sprint 4.5 milestone Nov 20, 2017
@AmyKort AmyKort modified the milestones: RBS 3 (Reliability, stability and bugs), RBS 2 (Reliability, stability and bugs) Nov 20, 2017
@LindsayYoung
Copy link
Contributor

LindsayYoung commented Jan 2, 2018

These views are a bit more complicated because we need to figure out which table the record is in and which schema it should use to pass the results.

We want to make sure that the views have a method in them named get that returns the query. It may be easiest to refactor those views to inherit the views.ApiResource, but there is probably more than one way to implement it.

Here are the relevant views

Reports view:
https://github.com/18F/openFEC/blob/34fa9465d9ec4febc601217a2bc078b4ca08b287/webservices/resources/reports.py#L100

Committee reports view:
https://github.com/18F/openFEC/blob/34fa9465d9ec4febc601217a2bc078b4ca08b287/webservices/resources/reports.py#L166

There is also an efiling reports view, I am not sure if that was in scope of the original ticket, but here is that view for reference: https://github.com/18F/openFEC/blob/34fa9465d9ec4febc601217a2bc078b4ca08b287/webservices/resources/reports.py#L246

@LindsayYoung
Copy link
Contributor

for context: high priority label comes from other ticket we consolidated to this one

@lbeaufort
Copy link
Member

PR's reviewed and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants