Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable candidate downloads #1875

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Enable candidate downloads #1875

merged 1 commit into from
Apr 2, 2018

Conversation

lbeaufort
Copy link
Member

@lbeaufort lbeaufort commented Mar 21, 2018

Summary (required)

Enable downloads from the prez/senate/house pages:

Steps to test locally

  • Point local cms to the dev API.
  • Check out this feature/enable-downloads branch of fec-cms repo
  • Point your cms to the dev API export FEC_API_URL=https://fec-dev-api.app.cloud.gov
  • Run cms locally. Don't forget to npm run build as this is a JavaScript change. You may need to restart your browser or test in an incognito window, depending on your browser and how aggressive it is about caching.
  • Test downloads for links above ^^

Screenshots

Before

image

After

image

Impacted areas of the application

List general components of the application that this PR will affect:

Related PRs

List related PRs against other branches:

branch PR
feature/enable-candidate-downloads (merged) fecgov/openFEC#3021

@lbeaufort lbeaufort changed the title Enable candidate downloads [WAIT FOR API CHANGE] Enable candidate downloads Mar 21, 2018
@lbeaufort lbeaufort changed the title [WAIT FOR API CHANGE] Enable candidate downloads Enable candidate downloads Apr 2, 2018
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks

@fec-jli fec-jli merged commit 54686fc into develop Apr 2, 2018
@lbeaufort lbeaufort deleted the feature/enable-downloads branch April 2, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants