Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cycles_has_activity return NULL in ofec_committee_history_mv #4126

Closed
2 tasks done
fec-jli opened this issue Dec 26, 2019 · 1 comment
Closed
2 tasks done

Fix cycles_has_activity return NULL in ofec_committee_history_mv #4126

fec-jli opened this issue Dec 26, 2019 · 1 comment

Comments

@fec-jli
Copy link
Contributor

fec-jli commented Dec 26, 2019

Ref PR: fecgov/fec-cms#3427

wrong query example: select * from ofec_committee_history_mv where committee_id='C00140590'
cycles_has_activity=[1982, 1984, 1986, 1988, 1990, 1992, 1994, 1996, 1998, 2000, 2002, 2004, 2006, 2008, 2010, 2012, 2014, 2016, 2018, 2020, NULL]

the correct query: select * from ofec_committee_history_mv where committee_id='C00105668'
cycles_has_activity=[1978, 1980, 1982, 1984, 1986, 1988, 1990, 1992, 1994, 1996, 1998, 2000, 2002, 2004, 2006, 2008, 2010, 2012, 2014, 2016, 2018, 2020]

  • find out the reason and fix MV
  • add test coverage to test this MV
@hcaofec
Copy link
Contributor

hcaofec commented Jan 14, 2020

PR was merged, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants