Remove 'None' value from list cycles_has_activity in ofec_committee_h…

[fec-jli]

Summary (required)

C00140590 committee profile page is throwing a server error.

• Resolves #[3426]
  Include a summary of proposed changes.
  modify cms load_committee_history function in views.py
  to clean cycles_has_activity, remove 'None' value in cycles_has_activity
  committee['cycles_has_activity'] = list(filter(None, committee.get('cycles_has_activity')))

Impacted areas of the application

committee profile page

How to test

1. checkout branch
   2)pytest
   ./manage.py test
   3)npm run test-single
2. test url, compare with prod.
   (wrong one)
   prod: https://www.fec.gov/data/committee/C00140590/
   local: http://127.0.0.1:8000/data/committee/C00140590/

(correct one should not affected)
prod: https://www.fec.gov/data/committee/C00105668/
local: http://127.0.0.1:8000/data/committee/C00105668/

We should create an separated issue to fix ofec_committee_history_mv

[jason-upchurch]

@fec-jli if we leave the logic as a control on the cms side rather than (or in addition to) sql, then should we also filter for any non-integer value rather than only None? For expediency I am approving now.

[fec-jli]

@fec-jli if we leave the logic as a control on the cms side rather than (or in addition to) sql, then should we also filter for any non-integer value rather than only None? For expediency I am approving now.

Thanks @jason-upchurch review it. for now, we only get 'None' value from sql query return, not sure if we will get other value. I will talk to database team to see any concern. Thanks.

[jason-upchurch]

@fec-jli if we leave the logic as a control on the cms side rather than (or in addition to) sql, then should we also filter for any non-integer value rather than only None? For expediency I am approving now.

Thanks @jason-upchurch review it. for now, we only get 'None' value from sql query return, not sure if we will get other value. I will talk to database team to see any concern. Thanks.

Thanks @fec-jli I think the datatype in the db is specified as integer so I agree nothing else should come back (because we rely on the root for correct behavior).

[pkfec]

Awesome @fec-jli! . This looks like a data issue. Thanks for adding extra validation when the cycles have bad data likeNone

[codecov-io]

Codecov Report

Merging #3427 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3427      +/-   ##
===========================================
+ Coverage    74.92%   74.92%   +<.01%     
===========================================
  Files          120      120              
  Lines         7349     7351       +2     
  Branches       642      642              
===========================================
+ Hits          5506     5508       +2     
  Misses        1843     1843

Impacted Files	Coverage Δ
fec/data/views.py	53.07% <100%> (+0.18%)	⬆️
fec/data/tests/test_committee.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59f13c...46106ba. Read the comment docs.

[jason-upchurch]

Looks great @fec-jli nice job!

[lbeaufort]

Looks great, thanks @fec-jli!