Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Update package-lock.json
How to test the changes locally
Reviewers
JS experts
@rfultz @johnnyporkchops @patphongs (any one will work)
Snyk vulnerability CLI experts
@fec-jli
Optional
@lbeaufort
Part 1: reproduce the report
snyk test --file=package-lock.json --dev
elliptic
and theserialize-javascript
vulnerabilities are shown on screen (different name for the elliptic one, but same vulnerability as reported through GitHub)Part 2: verify the fix
node_modules
andpackage-lock
npm i
snyk test --file=package-lock.json --dev
pytest