Use primary-key only count for Schedules B and E

[lbeaufort]

Summary (required)

• Resolves Implement primary key-only count for other endpoints #4429

Use primary-key only count for Schedules B and E

Reviewers

• Two developers please

How to test the changes locally

• Print out the query under get_query_plan in webservices.common.counts.py (Shortcut: subl webservices/common/counts.py:38)
• Do a Schedule B query, make sure it only selects sub_id column instead of many columns.
• Do a Schedule E query, make sure it only selects sub_id column instead of many columns.
  Example

SELECT disclosure.fec_fitem_sched_b.sub_id AS disclosure_fec_fitem_sched_b_sub_id 
FROM disclosure.fec_fitem_sched_b

Impacted areas of the application

List general components of the application that this PR will affect:

• /schedules/schedule_b/ endpoint count
• /schedules/schedule_e/ endpoint count

Related PRs

List related PRs against other branches:

branch	PR
feature/4368-modify-count-logic	Add flag ('use_pk_for_count') to only select primary key column for count query

[jason-upchurch]

Thanks for your work on this @lbeaufort -- looks good. Do you want to add anything to verify the use_pk_for_count to test_counts.py? I'm sure it's fine, but it probably couldn't hurt to add a simple automated test. I saw that the PR and the develop returned the same counts.

[lbeaufort]

Thanks for your work on this @lbeaufort -- looks good. Do you want to add anything to verify the use_pk_for_count to test_counts.py? I'm sure it's fine, but it probably couldn't hurt to add a simple automated test. I saw that the PR and the develop returned the same counts.

Thanks for your review, @jason-upchurch! This PR #4380 added an automated test and has some explanation of the testing approach.

[jason-upchurch]

Thanks for your work on this @lbeaufort -- looks good. Do you want to add anything to verify the use_pk_for_count to test_counts.py? I'm sure it's fine, but it probably couldn't hurt to add a simple automated test. I saw that the PR and the develop returned the same counts.

Thanks for your review, @jason-upchurch! This PR #4380 added an automated test and has some explanation of the testing approach.

Thank you @lbeaufort!

[hcaofec]

Download the feature branch, and tested as instructed. The queries for counting is working as expected. All tests are passed successfully. Good job!

SELECT disclosure.fec_fitem_sched_b.sub_id AS disclosure_fec_fitem_sched_b_sub_id FROM disclosure.fec_fitem_sched_b WHERE disclosure.fec_fitem_sched_b.cmte_tp IN (%(cmte_tp_1)s) AND disclosure.fec_fitem_sched_b.two_year_transaction_period IN (%(two_year_transaction_period_1)s)

SELECT ofec_sched_e_mv.sub_id AS ofec_sched_e_mv_sub_id FROM ofec_sched_e_mv WHERE get_cycle(ofec_sched_e_mv.rpt_yr) IN (%(get_cycle_1)s)

[hcaofec]

Look good, so approved.