Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5146-remove swagger-tools and upgrade gevent #5178

Merged
merged 1 commit into from
Jun 28, 2022
Merged

5146-remove swagger-tools and upgrade gevent #5178

merged 1 commit into from
Jun 28, 2022

Conversation

cnlucas
Copy link
Member

@cnlucas cnlucas commented Jun 27, 2022

Summary (required)

Swagger-tools is no longer being updated, and it doesn't seem like we need it, so we should remove it.

Before:

Screen Shot 2022-06-27 at 9 08 48 AM

Required reviewers

1-2 devs

How to test

  • run snyk test on an updated develop
  • checkout this branch
  • pyenv virtualenv 3.8.12 venv-test
  • pyenv activate venv-test
  • rm -rf node_modules
  • pip install -r requirements.txt && pip install -r requirements-dev.txt
  • npm i && npm run build
  • dropdb cfdm_test
  • createdb cfdm_test
  • invoke create_sample_db
  • python manage.py runserver
  • snyk test

pkfec
pkfec approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@pkfec pkfec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Swagger ui works as expected thanks @cnlucas

fec-jli
fec-jli approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

work as expected. Thanks

@fec-jli fec-jli merged commit 110e642 into develop Jun 28, 2022
@cnlucas cnlucas deleted the feature/5146-remove-swagger-tools branch July 22, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkfec pkfec pkfec approved these changes

@fec-jli fec-jli fec-jli approved these changes

@hcaofec hcaofec Awaiting requested review from hcaofec

Assignees
No one assigned
Labels
Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Snyk: High]dicer Denial of Service (DoS) (06/24/2022) [No remediation path available]
3 participants
@cnlucas @pkfec @fec-jli