[WIP] upgrade flask #5508
Merged
[WIP] upgrade flask #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpayton
commented
Jul 20, 2023
| ) | ||
| if env.get_credential("PRODUCTION"): | ||
| if env.get_credential("PRODUCTION") or env.get_credential("STAGE"): |
There was a problem hiding this comment.
Do we want to have api_key field in Stage as well?
Codecov Report
@@ Coverage Diff @@
## develop #5508 +/- ##
===========================================
+ Coverage 85.50% 85.58% +0.08%
===========================================
Files 81 81
Lines 8173 8227 +54
===========================================
+ Hits 6988 7041 +53
- Misses 1185 1186 +1
|
tmpayton
commented
Jul 20, 2023
| @@ -44,9 +44,9 @@ class Resource(six.with_metaclass(MethodResourceMeta, restful.Resource)): | |||
|
|
|||
|
|
|||
| API_KEY_ARG = fields.Str( | |||
| required=True, missing="DEMO_KEY", description=docs.API_KEY_DESCRIPTION, | |||
| missing="DEMO_KEY", description=docs.API_KEY_DESCRIPTION, | |||
There was a problem hiding this comment.
required = True caused an error when pushing to PROD. I was not able to reproduce this locally. But I tested using just missing and it worked on Stage.
I think the error is due to a change in webargs where multiple calls to use_kwargs causes a bug when one of them is required. Here is a comment mentioning this. Our situation is not exactly the same, but I think it's the same error.
cnlucas
approved these changes
Jul 31, 2023
pkfec
approved these changes
Jul 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
This PR upgrades flask. This is a continuation of the previous PR.
The only unreviewed changes are in utils.py
Required reviewers 2-3 Devs
Impacted areas of the application
Related PRs
Related PRs against other branches:
How to test
pip install -r requirements.txtsnyk test --file=requirements.txt --package-manager=pippytestflask run