Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, rdkafka pulls in
syn 1.0
vianum_enum 0.5
. Most parts of the Rust ecosystem have moved tosyn 2.0
, and it's annoying to have both in the dependency tree because it's pretty heavy in terms of compile time.I chose to first update
Cargo.lock
viacargo update
because it was very outdated, and to show that the actual lockfile diff for thenum_enum
upgrade you would also see elsewhere from this doesn't pull in anything extra. I can update the PR to only do the minimal lockfile upgrade if you prefer.I also checked for breaking changes.
num_enum
unfortunately doesn't have a changelog, but it seems like the only relevant changes are:#[default]
/#[num_enum(default)]
attributes, which you aren't using