Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys: Upgrade num_enum to 0.7 #724

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

svix-jplatte
Copy link
Contributor

@svix-jplatte svix-jplatte commented Sep 18, 2024

Currently, rdkafka pulls in syn 1.0 via num_enum 0.5. Most parts of the Rust ecosystem have moved to syn 2.0, and it's annoying to have both in the dependency tree because it's pretty heavy in terms of compile time.

I chose to first update Cargo.lock via cargo update because it was very outdated, and to show that the actual lockfile diff for the num_enum upgrade you would also see elsewhere from this doesn't pull in anything extra. I can update the PR to only do the minimal lockfile upgrade if you prefer.

I also checked for breaking changes. num_enum unfortunately doesn't have a changelog, but it seems like the only relevant changes are:

  • num_enum 0.6 changed some behavior w.r.t. #[default] / #[num_enum(default)] attributes, which you aren't using
  • num_enum 0.7 increases the minimum supported Rust version to 1.70.0, which matches the current MSRV here as of Update MSRV to 1.70 #722

@svix-jplatte
Copy link
Contributor Author

Gentle ping @benesch @davidblewett (you seem to have recently reviewed other PRs)

Copy link
Collaborator

@davidblewett davidblewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will check test results later.

@svix-jplatte
Copy link
Contributor Author

svix-jplatte commented Oct 7, 2024

CI results mostly match main, though (7.5.1, 3.6) succeeded there.
I guess test_produce_consume_consumer_nonempty_callback is flaky?

@davidblewett davidblewett merged commit 11790be into fede1024:master Oct 7, 2024
6 of 9 checks passed
@svix-jplatte svix-jplatte deleted the upgrade-num_enum branch October 7, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants