Version bumps #5
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh, crap, removing config is terrible. |
|
@sr-gi I believe we cracked it! Please take a look at the latest iteration in PR 🥳 |
|
Additional concerns with this version bump:
cc @Kixunil |
src/lib.rs
Outdated
| } | ||
| } | ||
|
|
||
| if let Some(last) = self.certs.last() { | ||
| if *last != end_entity.0 { |
There was a problem hiding this comment.
This is the only part I'm not 100% sure about, it would be good to double-check for a cert that is signed by letsencrypt
There was a problem hiding this comment.
I've dropped this custom validation after checking against letsencrypt certs and seeing failures. My tests were inconclusive though. Some of the failures seemed expected, i.e when I passed a certificate that was not provided by server to client
Maybe it's best to consider the whole custom validation changes as follow up improvement
There was a problem hiding this comment.
How did you manage to create the letsencytp cert for LND? I'll give it a go tomorrow and if we cannot get far we can just leave it as it was and tackle it down the line
There was a problem hiding this comment.
Let's test it together tomorrow
|
I'm a bit out of context here, but on my level of understanding LGTM. Please ping me once you want to land and there are no outstanding issues, if you need someone to approve. |
Tonic v0.7 introduced a breaking change removing direct tonic transport configuration with rustls::ClientConfig, reason being that tonic needs to avoid version lock with rustls, i.e changes in rustls APIs should not break tonic. The recommended workaround is to directly use hyper and tonic, avoiding tonic::transport:Channel within the InterceptedService, as applied in this commit
tonic-build v0.10.0 codegen produces types that use TryInto trait. To avail this in scope, we bump rust edition to 2021, thus including TryInto trait in rust prelude
|
For context, I think we could create our own custom certificate verifier based on: briansmith/webpki#127, which allows self-signed certs, and then pass it to |
I think this may actually be harder than I though. It requires copying a lot of functionality from |
- release includes changes introduced by fedimint#5
0.19.0to0.21.0and tonic from0.6.2to0.10.0. Tonic related dependencies are also bumpedrustls::ClientConfig, reason being that tonic needs to avoid version lock with rustls, i.e changes in rustls APIs should not break tonic. The recommended workaround is to directly use hyper and tonic, avoiding tonic::transporttonic-lndcodegen1.65.0