-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce nosync to speed up installability #38
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Miroslav Vadkerti <mvadkert@redhat.com>
a393222
to
7506ef5
Compare
@msrb PTAL pls |
|
Disabling sync for CI environment makes sense because we are not interested in resuming a test after a CI crash. |
Does nosync work again? https://bugzilla.redhat.com/show_bug.cgi?id=2019329 |
I run the testing on all supported Fedoras to confirm it does not cause a failure of the pipeline: |
Thanks all for the input. I will merge this once the above tests pass. |
ok, more work needed in the plan, as my current testing showed nothing (rsync was not enabled) |
# Use nosync to speed up dnf | ||
if grep -q fedora <<< "${PROFILE_NAME}"; then | ||
dnf -y install nosync | ||
export LD_PRELOAD=/usr/lib64/nosync/nosync.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that this env var is only set in the prepare
test, and not in the subsequent installability
test -- tmt likely spawns a new shell process for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if it would be better to simply enable nosync in mini-tps directly?
We have been using nosync in Mock for ages. It causes mostly problem when you mix architectures. In this scenario this be no brainer. I can only imagine theoretical issues with some qemu tests or multiarch packages (is there any remaining? I guess not). |
This speeds up most of the packages significantly, I would consider including it: