Don't declare exchanges when consuming #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI (by way of Twisted) does not declare exchanges when consuming, it assumes the exchange already exists. This seems reasonable, consumers will still learn about configuration mistakes during the binding process. This makes it impossible to consume from the public vhost in Fedora, so this is a quick bugfix release while the transition to Crochet and Twisted are worked on and polished. Fixes: fedora-infra#171 Signed-off-by: Jeremy Cline <jcline@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
- Coverage 94.91% 94.89% -0.02%
==========================================
Files 14 14
Lines 1455 1450 -5
Branches 190 189 -1
==========================================
- Hits 1381 1376 -5
Misses 55 55
Partials 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI (by way of Twisted) does not declare exchanges when consuming,
it assumes the exchange already exists. This seems reasonable, consumers
will still learn about configuration mistakes during the binding
process. This makes it impossible to consume from the public vhost in
Fedora, so this is a quick bugfix release while the transition to
Crochet and Twisted are worked on and polished.
Fixes: #171
Signed-off-by: Jeremy Cline jcline@redhat.com