Add an embedded HTTP server to monitor the service #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abompard
force-pushed
the
http-monitoring
branch
from
6d23a2b
to
98dd457
Compare
Conan-Kudo
approved these changes
Jul 12, 2024
jeremycline
requested changes
Jul 17, 2024
docs/user-guide/consuming.rst
Outdated
| monitor its state. You can configure the port in the configuration file under | ||
| the ``[monitoring]`` section, with ``address`` and ``port``. | ||
| The default address is empty, which means that the monitoring server will | ||
| listen on all interfaces. The default port is ``0``, which means that the |
There was a problem hiding this comment.
This is a slightly surprising behavior since 0 usually means "bind to a free port" (try, for example, nc -l ::1 0 and then see the port with ss -plnt).
Maybe just have the feature off if the section doesn't exist in the configuration and require both values to be set (or pick static defaults) if the section does exit.
fedora_messaging/config.py
Outdated
|
|
||
| { | ||
| 'address': '', # listen on all interfaces | ||
| 'port': 8070, |
There was a problem hiding this comment.
This doesn't line up with the documentation elsewhere and the code
abompard
force-pushed
the
http-monitoring
branch
from
98dd457
to
0895c7f
Compare
jeremycline
approved these changes
Jul 23, 2024
| ) | ||
|
|
||
| # Don't check the reject action or the message will be put back in the queue and loop forever | ||
| # Don't check a generic processing failure because it stops the consumer instantly and we can't look |
There was a problem hiding this comment.
I guess it could log the final stats on exit, if available, and then you could inspect the log, but whether you bother with all that is totally up to you.
See the "Monitoring" section in : https://fedora-messaging.readthedocs.io/en/develop/user-guide/consuming.html Fixes: fedora-infra#380 Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
abompard
force-pushed
the
http-monitoring
branch
from
0895c7f
to
efa8240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds an embedded HTTP server to monitor consumers and producers, and get statistics about activity.
Fixes: #380