Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Do not use deprecated util.pump, it's going away. #142

Closed
ChALkeR opened this issue Aug 25, 2015 · 0 comments
Closed

Do not use deprecated util.pump, it's going away. #142

ChALkeR opened this issue Aug 25, 2015 · 0 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Aug 25, 2015

util.pump was deprecated since nodejs v0.10, and there is an ongoing discussion on removing that in the next major version: nodejs/node#2531.

The line in question: lib/cmd/common/local.js#L557:

util.pump(fileStream, response);

should be probably replaced with

fileStream.pipe(response);

I am not making a pull request because I am not a user of this package and have not tested it.

@ChALkeR ChALkeR changed the title Do not use util.pump. Do not use deprecated util.pump, it's going away. Aug 25, 2015
deiga added a commit to deiga/fh-fhc that referenced this issue Oct 10, 2017
deiga added a commit to deiga/fh-fhc that referenced this issue Oct 17, 2017
deiga added a commit to deiga/fh-fhc that referenced this issue Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants