Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer1 #12

Closed
prudhomm opened this issue Oct 25, 2024 · 0 comments · Fixed by #28
Closed

Reviewer1 #12

prudhomm opened this issue Oct 25, 2024 · 0 comments · Fixed by #28
Assignees
Labels
Milestone

Comments

@prudhomm
Copy link
Member

prudhomm commented Oct 25, 2024

The present work provides an overview of the Ktirio Urban Building framework (KUB), starting with an overview of the workflow and a description of some of the main ingredients of the software stack and discusses some current results performed on EuroHPC JU supercomputers using an innovative CI/CD pipeline. Scaling results indicate that further improvement of file I/Os in the post- processing parts is needed for better efficiency with larger number of compute nodes.

Generally, this is an interesting work, but the reviewer would like authors to clarify the following:

  1. More detailed information of target PDEs and models should be provided. see Reviewer2 #9 and Add governing equation section  #6
  2. It is necessary to describe the size of the data to be handled. describe the size of the data to be handled. #13
  3. It is necessary to explain how users are expected to use the results and how this will be achieved. explain how users are expected to use the results and how this will be achieved. #14
  4. A detailed explanation of how important real-time processing is for this project is required.
  5. Detailed information of supercomputing environments are needed.
  6. It is also helpful if the information of total elapsed time is added to Fig.11. add information of total elapsed time in Fig.11 #17
@prudhomm prudhomm added this to the V2 milestone Oct 25, 2024
@prudhomm prudhomm self-assigned this Oct 25, 2024
@prudhomm prudhomm linked a pull request Nov 1, 2024 that will close this issue
@prudhomm prudhomm mentioned this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant