Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer2 #9

Closed
prudhomm opened this issue Oct 25, 2024 · 0 comments · Fixed by #29
Closed

Reviewer2 #9

prudhomm opened this issue Oct 25, 2024 · 0 comments · Fixed by #29
Assignees
Labels
Milestone

Comments

@prudhomm
Copy link
Member

prudhomm commented Oct 25, 2024

This paper summarizes developments for the Ktirio Urban Building (KUB)
framework, which in the long term should be used for energy simulations of cities
are parts thereof to enhance urban planning and the overall building energy
requirements. The frameworks builds on several open-source packages such as
Feel++ and CGAL algorithms. The various steps of postprocessing, the options for
the selection how detailed the city is resolved, heat transfer modelling, etc. are
described, such that a very nice overview of the project including CI/CD solutions
are presented. The paper is well written and easy comprehensible.

However,

details of mathematical models or computational methods are not at all included in the paper. Basically, the paper is an overall description of the software framework with its present and planned capabilities, but lacks a description of the algorithms usedin the various pre-, and postprocessing as well as simulaton steps.

I recommend to

  1. summarize the most important mathematical models 6 add governing equation section #7
  2. zummarize the most computing intensive algorithms with their parallelization strategy.

For example, it is difficult to understand the performance metric shown in Fig. 11 if no background information about the computational task is included.

@prudhomm prudhomm added this to the V2 milestone Oct 25, 2024
@prudhomm prudhomm self-assigned this Oct 25, 2024
This was referenced Oct 25, 2024
@prudhomm prudhomm linked a pull request Nov 1, 2024 that will close this issue
@prudhomm prudhomm mentioned this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant