Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterable hashCode fix #76

Merged
merged 8 commits into from
Jul 11, 2020
Merged

Iterable hashCode fix #76

merged 8 commits into from
Jul 11, 2020

Conversation

machinescream
Copy link
Contributor

@machinescream machinescream commented Jul 10, 2020

Status

READY

Breaking Changes

NO

Description

Before fixing, SingleEquatable with a list of zeros returns the same hashcode not depends on how much zeros in it. (closes #74)

Todos

  • [+] Tests
  • Documentation
  • [+] Examples

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.
Please, look at this issue: #74

@machinescream machinescream requested a review from felangel as a code owner July 10, 2020 16:14
@felangel felangel added the bug Something isn't working label Jul 10, 2020
@felangel
Copy link
Owner

Hi @Renesanse 👋
Thanks so much for opening a pull request! Could you please run the formatter and also add tests for the fix? Thanks again, I really appreciate it 🙏

@machinescream
Copy link
Contributor Author

I hope it's done =)

@felangel felangel merged commit e823f9d into felangel:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The same hashcode of Equatables with different length lists of zeros.
2 participants