add non-negative check in second parameter for subStr

felder · Mar 18, 2022 · 9e9321f · 9e9321f
1 parent f0a060e
commit 9e9321f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/builtins.go b/builtins.go
@@ -991,6 +991,11 @@ func builtinSubstr(i *interpreter, inputStr, inputFrom, inputLen value) (value,
 		return nil, makeRuntimeError(msg, i.getCurrentStackTrace())
 	}
 
+	if fromV.value < 0 {
+		msg := fmt.Sprintf("substr second parameter should be greater than zero, got %f", fromV.value)
+		return nil, makeRuntimeError(msg, i.getCurrentStackTrace())
+	}
+
 	lenV, err := i.getNumber(inputLen)
 	if err != nil {
 		msg := fmt.Sprintf("substr third parameter should be a number, got %s", inputLen.getType().name)