Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set GROUPNAME and avoid inferring it #8

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

felipecrs
Copy link
Owner

@felipecrs felipecrs commented Nov 20, 2024

This partially reverts e96e695, as I don't think it was a good idea.

But now, the user can pass a different groupname with GROUPNAME environment variable, like:

ARG USERNAME=username
ARG GROUPNAME=groupname
RUN <fixdockergid>/install.sh

While still falling back to USERNAME if GROUPNAME is not set.

Also, to avoid issues in runtime, we verify the presence of the user and group during install.sh execution.

@felipecrs felipecrs merged commit b603248 into master Nov 20, 2024
@felipecrs felipecrs deleted the allow-groupname branch November 20, 2024 05:34
@felipecrs felipecrs changed the title Allow to set GROUPNAME and avoid inferring it Allow to set GROUPNAME and avoid inferring it Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant