Include the build and prerelease to maintain consistency #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heya. Are you still working on this one? :) |
|
It's currently being used here. The current changes work well enough to serialize/deserialize a version number to/from a string, but I haven't made sure that all cases have been considered. |
|
oh hey cool! I didn't know about this project, but it's exactly the kind of project this package was built for, so I'm glad it's being useful :) Happy to take patches if you ever run into all the weird corner cases that I know are out there (there's so many. People's package.jsons are so messy). |
danielhuang
changed the title
|
I'd probably leave this as a single change. I'll submit more patches if I notice anything else. |
|
@danielhuang I just released this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.