Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist now fully support episodes #178

Closed
felix-hilden opened this issue May 8, 2020 · 1 comment
Closed

Playlist now fully support episodes #178

felix-hilden opened this issue May 8, 2020 · 1 comment
Assignees
Labels
change Change behaviour of an existing component enhancement New feature or improvement
Milestone

Comments

@felix-hilden
Copy link
Owner

Playlists support episodes in all calls. So we should definitely do something about that.

Names like playlist_tracks_... are a bit odd now. They could be changed to items or simply playlist_... if they are clear enough. We should also think about having only generic methods that accept URIs vs. specialised that accept IDs, or have both. But having only specialised would be odd, because filling a playlist with multiple types would require more calls.

@felix-hilden felix-hilden self-assigned this May 8, 2020
@felix-hilden felix-hilden added consideration Future decision to be discussed enhancement New feature or improvement labels May 8, 2020
@felix-hilden
Copy link
Owner Author

The calls that are affected with their relevant parameters are:

  • playlist_tracks
  • playlist_tracks_add(track_ids)
  • playlist_tracks_clear
  • playlist_tracks_remove(track_ids)
  • playlist_tracks_remove_indices
  • playlist_tracks_remove_occurrences(track_refs)
  • playlist_tracks_reorder
  • playlist_tracks_replace(track_ids)

I think the best thing to do is to shorten the names and change ID arguments to URIs. It shouldn't be too big of a burden on users, because the URIs are already provided in track objects, and conversion from other sources is easy. But the names would be a lot cleaner.

  • playlist_items
  • playlist_add(uris)
  • playlist_clear
  • playlist_remove(uris)
  • playlist_remove_indices
  • playlist_remove_occurrences(refs) (refs with uris)
  • playlist_reorder
  • playlist_replace(uris)

One thing we could do is simply deprecate the existing functions, because they are not invalid, and let them use the new ones internally.

@felix-hilden felix-hilden added change Change behaviour of an existing component and removed consideration Future decision to be discussed labels May 9, 2020
@felix-hilden felix-hilden added this to the v2.0.0 milestone May 9, 2020
@felix-hilden felix-hilden mentioned this issue May 9, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Change behaviour of an existing component enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant